Dogukan/etabs connector poc #406

dogukankaratas · 2024-11-23T17:30:26Z

First attempt to implement DUI3 to ETABS. 🎉

codecov · 2024-11-23T17:33:35Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.30%. Comparing base (85bd017) to head (fa496c7).
Report is 1 commits behind head on dev.

Additional details and impacted files

@@          Coverage Diff          @@
##             dev    #406   +/-   ##
=====================================
  Coverage   9.30%   9.30%           
=====================================
  Files        224     224           
  Lines       4234    4234           
  Branches     471     471           
=====================================
  Hits         394     394           
  Misses      3824    3824           
  Partials      16      16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bjoernsteinhagen · 2024-11-25T06:02:37Z

@dogukankaratas thinking about folder directories: ETABS/22/Speckle.Connectors.ETABS22 ? For future versions (same approach as Rhino)

bjoernsteinhagen · 2024-11-25T06:07:30Z

Working on my side too, nice @dogukankaratas! 🚀

bjoernsteinhagen

Not to be sorted in this PR but something for us to keep in mind:

Manual loading of the .dll file to get the plugin in ETABS? No way to get it recognised automatically? Maybe we contact ETABS support.

oguzhankoral · 2024-11-25T14:20:09Z

@dogukankaratas @bjoernsteinhagen please do not merge this PR in before having approval from @JR-Morgan or @adamhathcock

dogukankaratas · 2024-11-25T15:01:10Z

CI Build Failure:
CI checks are failing due to a local DLL dependency for CSIAPIv1. We're currently using a local DLL because there is no official NuGet package for it.

Background:

In the previous version we were using: https://www.nuget.org/packages/CSiAPIv1 which is net48 compatible. The latest CSI API has been updated for net8 compatibility

Required Action:

Need to publish a new NuGet package for the net8 compatible version
@JR-Morgan is already aware of this situation

Note: Once published, we can replace the local DLL reference with the new NuGet package.

- Migrated the proof-of-concept to a Shared project - Some renaming headache - Use of Speckle.CSI.API NGet package (thanks Jedd) - Basic selection info works - Ready for CNX-828 and CNX-835

- Renaming of the solution structure(s) outdated in the Local.sln

bjoernsteinhagen · 2024-11-28T00:04:44Z

Changes

From ETABS\Speckle.Connector.ETABS22.csproj to CSi\ETABS22\Speckle.Connectors.ETABS22.csproj and CSi\Shared\Speckle.Connectors.CSiShared.shproj
NuGet Speckle.CSI.API instead of dll reference

Check Failing

Running ./build.ps1 test in my terminal works no problem, PR is another thing.

I suspect Speckle.Connectors.sln and Local.sln are out of sync following all the folder movement and renaming from ETABS/Speckle.Connector.ETABSS22.csproj to CSI/ETABS22/Speckle.Connectors.ETABS22.csproj, @JR-Morgan able to give me a hand with this tomorrow?

But on a good note, we're interacting with the model and selecting things.

cc: @dogukankaratas, @oguzhankoral

Code style error

Connectors/CSi/Speckle.Connectors.CSiShared/Properties/launchSettings.json

oguzhankoral · 2024-11-28T10:22:39Z

Connectors/CSi/Speckle.Connectors.CSiShared/cPlugin.cs

@@ -0,0 +1,63 @@
+// NOTE: Plugin entry point must match the assembly name, otherwise hits you with a "Not found" error when loading plugin
+// TODO: Move ETABS implementation to csproj as part of CNX-835 and/or CNX-828
+namespace Speckle.Connectors.ETABS22;


wrong namespace?

Temp solution, that's why I marked as TODO. ETABS expects cPlugin and Form1 namespace match assembly name. When it was under CSiShared, it gave the "Not Found" error. Will make it more elegant in next series of Ticket(s)

very annoying

oguzhankoral · 2024-11-28T10:23:58Z

Connectors/CSi/Speckle.Connectors.CSiShared/Form1.cs

+
+// NOTE: Plugin entry point must match the assembly name, otherwise hits you with a "Not found" error when loading plugin
+// TODO: Move ETABS implementation to csproj as part of CNX-835 and/or CNX-828
+namespace Speckle.Connectors.ETABS22;


wrong namespace?

Same as cPlugin.cs :)

Could we also rename this form to "SpeckleForm" or something more descriptive

This caused us headache 😆 It needs to (for some reason) be named Form1.cs @dogukankaratas and I can't explain yet.

this is gross

Connectors/CSi/Speckle.Connectors.CSiShared/Form1.cs

adamhathcock · 2024-11-28T12:25:47Z

Connectors/CSi/Speckle.Connectors.CSiShared/HostApp/CSiSharedDocumentModelStore.cs

+  public CSiSharedDocumentModelStore(IJsonSerializer jsonSerializerSettings)
+    : base(jsonSerializerSettings) { }
+
+  protected override void HostAppSaveState(string modelCardState) => throw new NotImplementedException();


does this not throw yet?

Nope, not yet

dogukankaratas added 3 commits November 23, 2024 16:19

dui3 integration

4821857

registers necessary classes

6803130

adds solution to local

cd5e90c

dogukankaratas requested review from oguzhankoral and bjoernsteinhagen November 23, 2024 17:30

oguzhankoral assigned JR-Morgan Nov 23, 2024

bjoernsteinhagen reviewed Nov 25, 2024

View reviewed changes

Merge branch 'dev' into dogukan/etabs-connector-poc

8003a0a

bjoernsteinhagen approved these changes Nov 25, 2024

View reviewed changes

oguzhankoral requested a review from JR-Morgan November 25, 2024 14:19

oguzhankoral requested a review from adamhathcock November 25, 2024 14:20

updates packages.lock

036ab00

bjoernsteinhagen added 2 commits November 28, 2024 00:11

v3 Kick-Off

944be18

- Migrated the proof-of-concept to a Shared project - Some renaming headache - Use of Speckle.CSI.API NGet package (thanks Jedd) - Basic selection info works - Ready for CNX-828 and CNX-835

Renaming

a50109d

- Renaming of the solution structure(s) outdated in the Local.sln

bjoernsteinhagen added 4 commits November 28, 2024 10:39

Local.sln Updates

fe26aa1

Merge branch 'dev' into dogukan/etabs-connector-poc

3fe1d98

SDK 3.1.0-dev.200 changes

29d7f44

s_modality

2f84c2c

Code style error

oguzhankoral requested changes Nov 28, 2024

View reviewed changes

Remove launchSettings.json from shared

00bfe81

oguzhankoral approved these changes Nov 28, 2024

View reviewed changes

adamhathcock requested changes Nov 28, 2024

View reviewed changes

Removing null supression

fa496c7

adamhathcock approved these changes Nov 28, 2024

View reviewed changes

bjoernsteinhagen merged commit a99083f into dev Nov 28, 2024
5 checks passed

bjoernsteinhagen deleted the dogukan/etabs-connector-poc branch November 28, 2024 12:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dogukan/etabs connector poc #406

Dogukan/etabs connector poc #406

dogukankaratas commented Nov 23, 2024

codecov bot commented Nov 23, 2024 •

edited

Loading

bjoernsteinhagen commented Nov 25, 2024

bjoernsteinhagen commented Nov 25, 2024

bjoernsteinhagen left a comment

oguzhankoral commented Nov 25, 2024

dogukankaratas commented Nov 25, 2024 •

edited

Loading

bjoernsteinhagen commented Nov 28, 2024 •

edited

Loading

oguzhankoral Nov 28, 2024

bjoernsteinhagen Nov 28, 2024

oguzhankoral Nov 28, 2024

oguzhankoral Nov 28, 2024

bjoernsteinhagen Nov 28, 2024

clairekuang Nov 28, 2024

bjoernsteinhagen Nov 28, 2024

adamhathcock Nov 28, 2024

adamhathcock Nov 28, 2024

bjoernsteinhagen Nov 28, 2024

Dogukan/etabs connector poc #406

Dogukan/etabs connector poc #406

Conversation

dogukankaratas commented Nov 23, 2024

codecov bot commented Nov 23, 2024 • edited Loading

Codecov Report

bjoernsteinhagen commented Nov 25, 2024

bjoernsteinhagen commented Nov 25, 2024

bjoernsteinhagen left a comment

Choose a reason for hiding this comment

oguzhankoral commented Nov 25, 2024

dogukankaratas commented Nov 25, 2024 • edited Loading

bjoernsteinhagen commented Nov 28, 2024 • edited Loading

Changes

Check Failing

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Nov 23, 2024 •

edited

Loading

dogukankaratas commented Nov 25, 2024 •

edited

Loading

bjoernsteinhagen commented Nov 28, 2024 •

edited

Loading